]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dm-unstriped: cast an operand to sector_t to prevent potential uint32_t overflow
authorZichen Xie <zichenxie0106@gmail.com>
Mon, 21 Oct 2024 19:54:45 +0000 (14:54 -0500)
committerMikulas Patocka <mpatocka@redhat.com>
Mon, 4 Nov 2024 16:34:56 +0000 (17:34 +0100)
commit5a4510c762fc04c74cff264cd4d9e9f5bf364bae
tree66b8543b0a76a43a06cdedc73667029e04233b9d
parentfed13a5478680614ba97fc87e71f16e2e197912e
dm-unstriped: cast an operand to sector_t to prevent potential uint32_t overflow

This was found by a static analyzer.
There may be a potential integer overflow issue in
unstripe_ctr(). uc->unstripe_offset and uc->unstripe_width are
defined as "sector_t"(uint64_t), while uc->unstripe,
uc->chunk_size and uc->stripes are all defined as "uint32_t".
The result of the calculation will be limited to "uint32_t"
without correct casting.
So, we recommend adding an extra cast to prevent potential
integer overflow.

Fixes: 18a5bf270532 ("dm: add unstriped target")
Signed-off-by: Zichen Xie <zichenxie0106@gmail.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
drivers/md/dm-unstripe.c