]> www.infradead.org Git - users/jedix/linux-maple.git/commit
pinctrl: spacemit: fix double free of map
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 23 Oct 2024 08:39:47 +0000 (11:39 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 28 Oct 2024 12:54:04 +0000 (13:54 +0100)
commit5a18e2be454f51c7f698d47d8b2cf3b92a5a3ec1
tree47e4b67734af1ef26ac8c3a65e861776df80073f
parent3ad8d3ec6d87b16cdd336aa065d8e150096a192b
pinctrl: spacemit: fix double free of map

The map pointer is freed by pinctrl_utils_free_map().  It must not be a
devm_ pointer or it leads to a double free when the device is unloaded.

This is similar to a couple bugs Harshit Mogalapalli fixed earlier in
commits 3fd976afe974 ("pinctrl: nuvoton: fix a double free in
ma35_pinctrl_dt_node_to_map_func()") and 4575962aeed6 ("pinctrl: sophgo:
fix double free in cv1800_pctrl_dt_node_to_map()").

Fixes: a83c29e1d145 ("pinctrl: spacemit: add support for SpacemiT K1 SoC")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Yixun Lan <dlan@gentoo.org>
Link: https://lore.kernel.org/4b5f1306-dc01-4edc-96d3-b232b930ddf2@stanley.mountain
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/spacemit/pinctrl-k1.c