]> www.infradead.org Git - users/dwmw2/linux.git/commit
fbdev: arcfb: Fix error handling in arcfb_probe()
authorZongjie Li <u202112089@hust.edu.cn>
Tue, 9 May 2023 11:27:26 +0000 (19:27 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 May 2023 16:32:33 +0000 (17:32 +0100)
commit5a08a72da35bf2dd6ba63bd6ee7210a1d25dbefd
treefa36b7a49df3ed328b9474b763215d2be44a2d79
parentdcd289136bccf2bdd519ee1eb355ed71c73cbe75
fbdev: arcfb: Fix error handling in arcfb_probe()

[ Upstream commit 5a6bef734247c7a8c19511664ff77634ab86f45b ]

Smatch complains that:
arcfb_probe() warn: 'irq' from request_irq() not released on lines: 587.

Fix error handling in the arcfb_probe() function. If IO addresses are
not provided or framebuffer registration fails, the code will jump to
the err_addr or err_register_fb label to release resources.
If IRQ request fails, previously allocated resources will be freed.

Fixes: 1154ea7dcd8e ("[PATCH] Framebuffer driver for Arc LCD board")
Signed-off-by: Zongjie Li <u202112089@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/fbdev/arcfb.c