]> www.infradead.org Git - users/willy/xarray.git/commit
ext4: dax: keep orphan list before truncate overflow allocated blocks
authoryangerkun <yangerkun@huawei.com>
Thu, 29 Aug 2024 11:02:22 +0000 (19:02 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 4 Sep 2024 02:14:16 +0000 (22:14 -0400)
commit59efe53e380ee305ec11378233adb6aaebe1856c
tree029ddbf5b4e47da3ea8cda31865476a1ff0aa0d0
parenta2187431c395cdfbf144e3536f25468c64fc7cfa
ext4: dax: keep orphan list before truncate overflow allocated blocks

Any extending write for ext4 requires the inode to be placed on the
orphan list before the actual write. In addition, the inode can be
actually removed from the orphan list only after all writes are
completed. Otherwise we'd leave allocated blocks beyond i_disksize if we
could not copy all the data into allocated block and e2fsck would
complain.

Currently, direct IO and buffered IO comply with this logic(buffered
IO will truncate all overflow allocated blocks that has not been
written successfully, and direct IO will truncate all allocated blocks
when error occurs). However, dax write break this since dax write will
remove the inode from the orphan list by calling
ext4_handle_inode_extension unconditionally during extending write.

We add a argument to help determine does we do a fully write, and for
the case not fully write, we leave the inode on the orphan list, and the
latter ext4_inode_extension_cleanup will help us truncate the overflow
allocated blocks, and then remove the inode from the orphan list.

Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240829110222.126685-1-yangerkun@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/file.c