]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: ath12k: fix NULL pointer access in ath12k_mac_op_get_survey()
authorAaradhana Sahu <quic_aarasahu@quicinc.com>
Tue, 11 Jun 2024 03:10:16 +0000 (08:40 +0530)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 19 Jun 2024 14:00:51 +0000 (17:00 +0300)
commit59ca26c9a6e844204d25299774caa5441c0e68eb
tree11f41d4fd8838b74a8d23bd493286a92b66dad95
parentaadeee47e9d7ae98f7116f63fa63fcceffffc65c
wifi: ath12k: fix NULL pointer access in ath12k_mac_op_get_survey()

Smatch throws below error

drivers/net/wireless/ath/ath12k/mac.c:8318 ath12k_mac_op_get_survey() error: we previously assumed 'sband' could be null

Currently, we access sband inside the null check of the sband
in ath12k_mac_op_get_survey().

Fix this issue by removing the entire if block, because decrement
idx is unnecessary since there are no more band to test.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Fixes: 70e3be54bbdd ("wifi: ath12k: fix survey dump collection in 6 GHz")
Signed-off-by: Aaradhana Sahu <quic_aarasahu@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20240611031017.297927-2-quic_aarasahu@quicinc.com
drivers/net/wireless/ath/ath12k/mac.c