]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dtrace: use copy_from_user() when walking userspace stacks
authorNick Alcock <nick.alcock@oracle.com>
Fri, 29 Jan 2016 14:53:46 +0000 (14:53 +0000)
committerNick Alcock <nick.alcock@oracle.com>
Wed, 3 Feb 2016 16:36:59 +0000 (16:36 +0000)
commit591cd72719494bc6db4c7522ad4d2ea7f079b247
tree35925b0880340084464f6383952b862513f217eb
parentfda8f00c97f148317032847639744c42217b02f3
dtrace: use copy_from_user() when walking userspace stacks

We were using get_user(), but that doesn't reliably work on all
platforms (such as SPARC64) and cannot trap faults, which meant we were
jumping through extra hoops to trap faults when copy_from_user() does
that anyway.

The extra copy is notably less efficient (since we end up looping over,
and copying, essentially the entire user stack in one-word increments),
but has the advantage of actually working.

Orabug: 22629102
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Acked-by: Kris Van Hees <kris.van.hees@oracle.com>
dtrace/dtrace_isa.c