]> www.infradead.org Git - users/jedix/linux-maple.git/commit
i40e: Fix order of checks when enabling/disabling autoneg in ethtool
authorCatherine Sullivan <catherine.sullivan@intel.com>
Mon, 28 Sep 2015 18:16:58 +0000 (14:16 -0400)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 10 Mar 2016 16:33:04 +0000 (08:33 -0800)
commit588bfbde0e070c906de0b7c8aaf2460e7bbe7ae2
treef2f7d42ff8423f3b62ebffc306353f6b29d6cc14
parent9bc894b4c55ab57ca3562f3e0a401bbb393fb4a3
i40e: Fix order of checks when enabling/disabling autoneg in ethtool

Orabug: 22342532

We were previously checking if autoneg was allowed to change before
checking if autoneg was changing. We need to do this in the other order
or else we will erroneously return EINVAL when autoneg is not changing.

Change-ID: Iff9f7d1c9bddc1ad1e5d227d4f42754f90155410
Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
(cherry picked from commit 3ce12ee9d8f9ae245f38e6acbd32625d8e002c5b)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/ethernet/intel/i40e/i40e_ethtool.c