]> www.infradead.org Git - users/dwmw2/linux.git/commit
s390/stacktrace: Use break instead of return statement
authorHeiko Carstens <hca@linux.ibm.com>
Mon, 18 Nov 2024 12:14:07 +0000 (13:14 +0100)
committerHeiko Carstens <hca@linux.ibm.com>
Thu, 21 Nov 2024 11:44:07 +0000 (12:44 +0100)
commit588a9836a4ef7ec3bfcffda526dfa399637e6cfc
treef62e36972a50a6ad8c529d79e0af319358184ef0
parent2f32cc40f1440a6aa9e7396af41db79bece67bb2
s390/stacktrace: Use break instead of return statement

arch_stack_walk_user_common() contains a return statement instead of a
break statement in case store_ip() fails while trying to store a callchain
entry of a user space process.
This may lead to a missing pagefault_enable() call.

If this happens any subsequent page fault of the process won't be resolved
by the page fault handler and this in turn will lead to the process being
killed.

Use a break instead of a return statement to fix this.

Fixes: ebd912ff9919 ("s390/stacktrace: Merge perf_callchain_user() and arch_stack_walk_user()")
Cc: stable@vger.kernel.org
Reviewed-by: Jens Remus <jremus@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
arch/s390/kernel/stacktrace.c