]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rtla/osnoise: Better report when histogram is empty
authorLuis Claudio R. Goncalves <lgoncalv@redhat.com>
Wed, 12 Jun 2024 10:36:22 +0000 (07:36 -0300)
committerDaniel Bristot de Oliveira <bristot@kernel.org>
Fri, 21 Jun 2024 08:19:53 +0000 (10:19 +0200)
commit587f05a88bd49c0c1f4c1b900787cedef461a902
treea83dd29485855c6c98f4c21bed9bf8ca0d0e45a0
parent59237b0c962e8a4e03a7666b8c1d047c262f236e
rtla/osnoise: Better report when histogram is empty

When osnoise hist does not observe any samples above the threshold,
no entries are recorded and the final report shows empty entries
for the usual statistics (count, min, max, avg):

    [~]# osnoise hist -d 5s -T 500
    # RTLA osnoise histogram
    # Time unit is microseconds (us)
    # Duration:   0 00:00:05
    Index
    over:
    count:
    min:
    avg:
    max:

That could lead users to confusing interpretations of the results.

A simple solution is to report 0 for count and the statistics, making it
clear that no noise (above the defined threshold) was observed:

    [~]# osnoise hist -d 5s -T 500
    # RTLA osnoise histogram
    # Time unit is microseconds (us)
    # Duration:   0 00:00:05
    Index
    over: 0
    count: 0
    min: 0
    avg: 0
    max: 0

Link: https://lkml.kernel.org/r/Zml6JmH5cbS7-HfZ@uudg.org
Cc: Daniel Bristot de Oliveira <bristot@kernel.org>
Cc: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Reviewed-by: John Kacur <jkacur@redhat.com>
Signed-off-by: Luis Claudio R. Goncalves <lgoncalv@redhat.com>
Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org>
tools/tracing/rtla/src/osnoise_hist.c