]> www.infradead.org Git - users/dwmw2/qemu.git/commit
parallels: fix ext_off assertion failure due to overflow
authorDenis Rastyogin <gerben@altlinux.org>
Thu, 12 Dec 2024 10:41:22 +0000 (13:41 +0300)
committerStefan Hajnoczi <stefanha@redhat.com>
Thu, 30 Jan 2025 20:22:28 +0000 (15:22 -0500)
commit58607752d173438994d28dea7e2c2587726663e6
treeaa853b3c333776ce39102cce46897a8fd776167c
parent871af84dd599fab68c8ed414d9ecbdb2bcfc5801
parallels: fix ext_off assertion failure due to overflow

This error was discovered by fuzzing qemu-img.

When ph.ext_off has a sufficiently large value, the operation
le64_to_cpu(ph.ext_off) << BDRV_SECTOR_BITS in
parallels_read_format_extension() can cause an overflow in int64_t.
This overflow triggers the assert(ext_off > 0)
check in block/parallels-ext.c: parallels_read_format_extension(),
leading to a crash.

This commit adds a check to prevent overflow when shifting ph.ext_off
by BDRV_SECTOR_BITS, ensuring that the value remains within a valid range.

Reported-by: Leonid Reviakin <L.reviakin@fobos-nt.ru>
Signed-off-by: Denis Rastyogin <gerben@altlinux.org>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Message-ID: <20241212104212.513947-2-gerben@altlinux.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/parallels.c