]> www.infradead.org Git - users/willy/xarray.git/commit
rpmb: fix error path in rpmb_dev_register()
authorJens Wiklander <jens.wiklander@linaro.org>
Mon, 2 Sep 2024 10:58:03 +0000 (12:58 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 4 Sep 2024 13:04:57 +0000 (15:04 +0200)
commit5854809b51f4e3868202d9b45e628133d76b48cd
tree97bd1985b05459d3e67b75fe157f47b0ebcf555a
parentedd3183c5c5f9fe7aede49a41678556bc8bf618f
rpmb: fix error path in rpmb_dev_register()

Until this patch was rpmb_dev_register() always freeing rdev in the error
path. However, past device_register() it must not do that since the memory
is now managed by the device even if it failed to register properly. So fix
this by doing a put_device() before returning the error code.

Fixes the smatch warning:
        drivers/misc/rpmb-core.c:204 rpmb_dev_register()
        warn: freeing device managed memory (leak): 'rdev'

Fixes: 1e9046e3a154 ("rpmb: add Replay Protected Memory Block (RPMB) subsystem")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Link: https://lore.kernel.org/r/20240902105803.2885544-1-jens.wiklander@linaro.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/misc/rpmb-core.c