]> www.infradead.org Git - users/dwmw2/linux.git/commit
mptcp: annotate data-races around subflow->fully_established
authorGang Yan <yangang@kylinos.cn>
Mon, 21 Oct 2024 15:14:04 +0000 (17:14 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 28 Oct 2024 22:55:45 +0000 (15:55 -0700)
commit581c8cbfa934aaa555daa4e843242fcecc160f05
tree464e4a9cebda2782bf34c240c8a239483578ca9d
parenta42f3076648e0b507de9039f8085edcc10b35fb7
mptcp: annotate data-races around subflow->fully_established

We introduce the same handling for potential data races with the
'fully_established' flag in subflow as previously done for
msk->fully_established.

Additionally, we make a crucial change: convert the subflow's
'fully_established' from 'bit_field' to 'bool' type. This is
necessary because methods for avoiding data races don't work well
with 'bit_field'. Specifically, the 'READ_ONCE' needs to know
the size of the variable being accessed, which is not supported in
'bit_field'. Also, 'test_bit' expect the address of 'bit_field'.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/516
Signed-off-by: Gang Yan <yangang@kylinos.cn>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20241021-net-next-mptcp-misc-6-13-v1-2-1ef02746504a@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/diag.c
net/mptcp/options.c
net/mptcp/protocol.c
net/mptcp/protocol.h
net/mptcp/subflow.c