]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: phy: aquantia: fix return value check in aqr107_config_mdi()
authorDaniel Golle <daniel@makrotopia.org>
Sun, 13 Oct 2024 13:16:44 +0000 (14:16 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Oct 2024 16:53:53 +0000 (09:53 -0700)
commit57c28e93694de1d95dfdc70ea5c0e3008b3376f7
treedabdba782ab98dadffdd9b3e1a6108b679a5d05e
parenta581ed81940db0244eae5a8078345f3dcd88f0c6
net: phy: aquantia: fix return value check in aqr107_config_mdi()

of_property_read_u32() returns -EINVAL in case the property cannot be
found rather than -ENOENT. Fix the check to not abort probing in case
of the property being missing, and also in case CONFIG_OF is not set
which will result in -ENOSYS.

Fixes: a2e1ba275eae ("net: phy: aquantia: allow forcing order of MDI pairs")
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Closes: https://lore.kernel.org/all/114b4c03-5d16-42ed-945d-cf78eabea12b@nvidia.com/
Suggested-by: Hans-Frieder Vogt <hfdevel@gmx.net>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://patch.msgid.link/f8282e2fc6a5ac91fe91491edc7f1ca8f4a65a0d.1728825323.git.daniel@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/aquantia/aquantia_main.c