]> www.infradead.org Git - nvme.git/commit
nvme-tcp: fix connect failure on receiving partial ICResp PDU
authorCaleb Sander Mateos <csander@purestorage.com>
Fri, 24 Jan 2025 18:43:10 +0000 (11:43 -0700)
committerKeith Busch <kbusch@kernel.org>
Tue, 18 Feb 2025 15:37:02 +0000 (07:37 -0800)
commit578539e0969028f711c34d9a4565931edfe1d730
tree7a7c13fabafa274d47eb7b6cdbf820830cf17d7b
parentcd513e0434c3e736c549bc99bf7982658b25114d
nvme-tcp: fix connect failure on receiving partial ICResp PDU

nvme_tcp_init_connection() attempts to receive an ICResp PDU but only
checks that the return value from recvmsg() is non-negative. If the
sender closes the TCP connection or sends fewer than 128 bytes, this
check will pass even though the full PDU wasn't received.

Ensure the full ICResp PDU is received by checking that recvmsg()
returns the expected 128 bytes.

Additionally set the MSG_WAITALL flag for recvmsg(), as a sender could
split the ICResp over multiple TCP frames. Without MSG_WAITALL,
recvmsg() could return prematurely with only part of the PDU.

Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/tcp.c