]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: mdiobus: fix an OF node reference leak
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Wed, 18 Dec 2024 03:51:06 +0000 (12:51 +0900)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 19 Dec 2024 10:45:42 +0000 (11:45 +0100)
commit572af9f284669d31d9175122bbef9bc62cea8ded
tree77e36860b79070c5fc1c450b78f7c48a4c272d08
parentb4adc04954592cb9f2e5dc796c5119c4d4c9b906
net: mdiobus: fix an OF node reference leak

fwnode_find_mii_timestamper() calls of_parse_phandle_with_fixed_args()
but does not decrement the refcount of the obtained OF node. Add an
of_node_put() call before returning from the function.

This bug was detected by an experimental static analysis tool that I am
developing.

Fixes: bc1bee3b87ee ("net: mdiobus: Introduce fwnode_mdiobus_register_phy()")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20241218035106.1436405-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/mdio/fwnode_mdio.c