]> www.infradead.org Git - users/jedix/linux-maple.git/commit
acct: perform last write from workqueue
authorChristian Brauner <brauner@kernel.org>
Tue, 11 Feb 2025 17:15:59 +0000 (18:15 +0100)
committerChristian Brauner <brauner@kernel.org>
Wed, 12 Feb 2025 11:24:16 +0000 (12:24 +0100)
commit56d5f3eba3f5de0efdd556de4ef381e109b973a9
tree9f106bc7a0991599926abeda890de6052446f6db
parenta64dcfb451e254085a7daee5fe51bf22959d52d3
acct: perform last write from workqueue

In [1] it was reported that the acct(2) system call can be used to
trigger NULL deref in cases where it is set to write to a file that
triggers an internal lookup. This can e.g., happen when pointing acc(2)
to /sys/power/resume. At the point the where the write to this file
happens the calling task has already exited and called exit_fs(). A
lookup will thus trigger a NULL-deref when accessing current->fs.

Reorganize the code so that the the final write happens from the
workqueue but with the caller's credentials. This preserves the
(strange) permission model and has almost no regression risk.

This api should stop to exist though.

Link: https://lore.kernel.org/r/20250127091811.3183623-1-quzicheng@huawei.com
Link: https://lore.kernel.org/r/20250211-work-acct-v1-1-1c16aecab8b3@kernel.org
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: Zicheng Qu <quzicheng@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
kernel/acct.c