]> www.infradead.org Git - users/dwmw2/linux.git/commit
platform/x86: thinkpad_acpi: Move tpacpi_driver_event() call to tpacpi_input_send_key()
authorHans de Goede <hdegoede@redhat.com>
Wed, 24 Apr 2024 12:28:24 +0000 (14:28 +0200)
committerHans de Goede <hdegoede@redhat.com>
Mon, 29 Apr 2024 09:44:13 +0000 (11:44 +0200)
commit56b3667d4ed34fe21de878b49eb964facc75b0d4
treea85770b167d7a499141f8ecb8c57bb0a886e6e70
parentc1a8c7f1dc2ff4e0041fd333317bca06615fbb9e
platform/x86: thinkpad_acpi: Move tpacpi_driver_event() call to tpacpi_input_send_key()

All callers of tpacpi_input_send_key() first call tpacpi_driver_event(),
move the tpacpi_driver_event() inside tpacpi_input_send_key() to avoid
code duplication.

For the original hotkey codes 0x1001 - 0x1020 tpacpi_driver_event() never
returns true. So the added "return true;" inside tpacpi_input_send_key()
never happens when called from tpacpi_hotkey_send_key() so behavior does
not change.

Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240424122834.19801-15-hdegoede@redhat.com
drivers/platform/x86/thinkpad_acpi.c