]> www.infradead.org Git - users/dwmw2/linux.git/commit
usb: gadget: udc: renesas_usb3: Fix sysfs interface of "role"
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Wed, 31 Jul 2019 10:15:43 +0000 (19:15 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Aug 2019 08:50:20 +0000 (10:50 +0200)
commit56a3eb5fa5d024794c5c62edc0e7b5864aa68bcb
treefcabec5bac42530412ce6bb777977b1b7522f6fc
parent282a771475c2016ef77871f4438d9aaf9c8aa2b7
usb: gadget: udc: renesas_usb3: Fix sysfs interface of "role"

commit 5dac665cf403967bb79a7aeb8c182a621fe617ff upstream.

Since the role_store() uses strncmp(), it's possible to refer
out-of-memory if the sysfs data size is smaller than strlen("host").
This patch fixes it by using sysfs_streq() instead of strncmp().

Fixes: cc995c9ec118 ("usb: gadget: udc: renesas_usb3: add support for usb role swap")
Cc: <stable@vger.kernel.org> # v4.12+
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/renesas_usb3.c