]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nui: Fix dma_mapping_error() check
authorThomas Fourier <fourier.thomas@gmail.com>
Mon, 30 Jun 2025 08:36:43 +0000 (10:36 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 2 Jul 2025 11:00:58 +0000 (12:00 +0100)
commit561aa0e22b70a5e7246b73d62a824b3aef3fc375
treebb2e8cc6fb1ab67db7585b90c432dff62bb44e97
parent34a500caf48c47d5171f4aa1f237da39b07c6157
nui: Fix dma_mapping_error() check

dma_map_XXX() functions return values DMA_MAPPING_ERROR as error values
which is often ~0.  The error value should be tested with
dma_mapping_error().

This patch creates a new function in niu_ops to test if the mapping
failed.  The test is fixed in niu_rbr_add_page(), added in
niu_start_xmit() and the successfully mapped pages are unmaped upon error.

Fixes: ec2deec1f352 ("niu: Fix to check for dma mapping errors.")
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sun/niu.c
drivers/net/ethernet/sun/niu.h