]> www.infradead.org Git - users/hch/configfs.git/commit
sfc: Don't invoke xdp_do_flush() from netpoll.
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 2 Oct 2024 12:58:37 +0000 (14:58 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Oct 2024 22:42:00 +0000 (15:42 -0700)
commit55e802468e1d38dec8e25a2fdb6078d45b647e8c
tree5d20bf8d3a9f311bdd625ce3afbe990f33204662
parenta842e443ca8184f2dc82ab307b43a8b38defd6a5
sfc: Don't invoke xdp_do_flush() from netpoll.

Yury reported a crash in the sfc driver originated from
netpoll_send_udp(). The netconsole sends a message and then netpoll
invokes the driver's NAPI function with a budget of zero. It is
dedicated to allow driver to free TX resources, that it may have used
while sending the packet.

In the netpoll case the driver invokes xdp_do_flush() unconditionally,
leading to crash because bpf_net_context was never assigned.

Invoke xdp_do_flush() only if budget is not zero.

Fixes: 401cb7dae8130 ("net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.")
Reported-by: Yury Vostrikov <mon@unformed.ru>
Closes: https://lore.kernel.org/5627f6d1-5491-4462-9d75-bc0612c26a22@app.fastmail.com
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://patch.msgid.link/20241002125837.utOcRo6Y@linutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/efx_channels.c
drivers/net/ethernet/sfc/siena/efx_channels.c