]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: stmmac: drop the ethtool begin() callback
authorAndrew Halaney <ahalaney@redhat.com>
Thu, 29 Aug 2024 20:48:44 +0000 (15:48 -0500)
committerDavid S. Miller <davem@davemloft.net>
Mon, 2 Sep 2024 12:44:09 +0000 (13:44 +0100)
commit55ddb6c5a3aef8d8658fe31b1ddda007693ae797
tree2bc9cfa9c83b8f75a5882a48fd5ec9a9d3955d99
parent221f9cce949ac8042f65b71ed1fde13b99073256
net: stmmac: drop the ethtool begin() callback

This callback doesn't seem to serve much purpose, and prevents things
like:

    - systemd.link files from disabling autonegotiation
    - carrier detection in NetworkManager
    - any ethtool setting

prior to userspace bringing the link up.

The only fear I can think of is accessing unclocked resources due to
pm_runtime, but ethtool ioctls handle that as of commit
f32a21376573 ("ethtool: runtime-resume netdev parent before ethtool ioctl ops")

Reviewed-by: Dmitry Dolenko <d.dolenko@metrotek.ru>
Tested-by: Dmitry Dolenko <d.dolenko@metrotek.ru>
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c