]> www.infradead.org Git - nvme.git/commit
nvmet-tcp: fix kernel crash if commands allocation fails
authorMaurizio Lombardi <mlombard@redhat.com>
Wed, 21 Aug 2024 14:28:26 +0000 (16:28 +0200)
committerKeith Busch <kbusch@kernel.org>
Mon, 26 Aug 2024 23:00:52 +0000 (16:00 -0700)
commit5572a55a6f830ee3f3a994b6b962a5c327d28cb3
tree6ce601118798d7c679151a556120c5dd465054d3
parent5a6d3a638c93881b7a7c13df870238b91399578a
nvmet-tcp: fix kernel crash if commands allocation fails

If the commands allocation fails in nvmet_tcp_alloc_cmds()
the kernel crashes in nvmet_tcp_release_queue_work() because of
a NULL pointer dereference.

  nvmet: failed to install queue 0 cntlid 1 ret 6
  Unable to handle kernel NULL pointer dereference at
         virtual address 0000000000000008

Fix the bug by setting queue->nr_cmds to zero in case
nvmet_tcp_alloc_cmd() fails.

Fixes: 872d26a391da ("nvmet-tcp: add NVMe over TCP target driver")
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/tcp.c