]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net/rds: Fix incorrect bigger vs. smaller IP address check
authorHåkon Bugge <Haakon.Bugge@oracle.com>
Tue, 26 Jun 2018 14:14:06 +0000 (16:14 +0200)
committerBrian Maly <brian.maly@oracle.com>
Thu, 5 Jul 2018 19:13:31 +0000 (15:13 -0400)
commit556a3ad9f9e165946baa7c51970cac1cc4b3ffe8
treed5d4dfd1aa51825028d0219fec4357b4623cc14c
parent39ea581b15e85beb1ad1838b6cb861feafac1fbc
net/rds: Fix incorrect bigger vs. smaller IP address check

In commit d8bd5dfb5de4 ("net/rds: use one sided reconnection during a
race"), the function rds_addr_cmp() was called without comparing the
return value to less-than or bigger-than-equal to zero.

This led to a situation where both peers thought they were the winner,
and consequently, racing RDS connections didn't form or took a long
time to form.

The issue is fixed by this commit.

Orabug: 28236599

Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Suggested-by: Ka-Cheong Poon <ka-cheong.poon@oracle.com>
Fixes: d8bd5dfb5de4 ("net/rds: use one sided reconnection during a race")
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
(cherry picked from commit 653ccd08be01f82c6129f5060bd8110489aca110
repo UEK/linux-hbugge-public.git)

Signed-off-by: Brian Maly <brian.maly@oracle.com>
Conflicts:
   * Had to "rename" the SHA of the Fixes: uek-5-master commit to
     the correct one for uek-4.1-qu7.

Signed-off-by: Brian Maly <brian.maly@oracle.com>
net/rds/threads.c