]> www.infradead.org Git - users/hch/misc.git/commit
selftests: net: give up on the cmsg_time accuracy on slow machines
authorJakub Kicinski <kuba@kernel.org>
Thu, 16 Jan 2025 02:01:05 +0000 (18:01 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 18 Jan 2025 02:36:14 +0000 (18:36 -0800)
commit54ea680b759c4d76de16381e4d2a4623653b2f9f
tree099ffb3a54938e4bff0bb33592c26a2945622e14
parent7d2eba0f83a59d360ed1e77ed2778101a6e3c4a1
selftests: net: give up on the cmsg_time accuracy on slow machines

Commit b9d5f5711dd8 ("selftests: net: increase the delay for relative
cmsg_time.sh test") widened the accepted value range 8x but we still
see flakes (at a rate of around 7%).

Return XFAIL for the most timing sensitive test on slow machines.

Before:

  # ./cmsg_time.sh
    Case UDPv4  - TXTIME rel returned '8074us - 7397us < 4000', expected 'OK'
  FAIL - 1/36 cases failed

After:

  # ./cmsg_time.sh
    Case UDPv4  - TXTIME rel returned '1123us - 941us < 500', expected 'OK' (XFAIL)
    Case UDPv6  - TXTIME rel returned '1227us - 776us < 500', expected 'OK' (XFAIL)
  OK

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250116020105.931338-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/cmsg_time.sh