]> www.infradead.org Git - linux.git/commit
dmaengine: altera-msgdma: properly free descriptor in msgdma_free_descriptor
authorOlivier Dautricourt <olivierdautricourt@gmail.com>
Sat, 8 Jun 2024 21:31:48 +0000 (23:31 +0200)
committerVinod Koul <vkoul@kernel.org>
Tue, 11 Jun 2024 16:20:55 +0000 (21:50 +0530)
commit54e4ada1a4206f878e345ae01cf37347d803d1b1
tree1cda40d6345f9a4f066d45861b66f84f9f0c9bf7
parentd3ddfab0969b19a7dee3753010bb3ea94a0cccd1
dmaengine: altera-msgdma: properly free descriptor in msgdma_free_descriptor

Remove list_del call in msgdma_chan_desc_cleanup, this should be the role
of msgdma_free_descriptor. In consequence replace list_add_tail with
list_move_tail in msgdma_free_descriptor.

This fixes the path:
   msgdma_free_chan_resources -> msgdma_free_descriptors ->
   msgdma_free_desc_list -> msgdma_free_descriptor

which does not correctly free the descriptors as first nodes were not
removed from the list.

Signed-off-by: Olivier Dautricourt <olivierdautricourt@gmail.com>
Tested-by: Olivier Dautricourt <olivierdautricourt@gmail.com>
Link: https://lore.kernel.org/r/20240608213216.25087-3-olivierdautricourt@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/altera-msgdma.c