]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net/mlx4_en: Prevent potential integer overflow calculating Hz
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 28 May 2025 08:11:09 +0000 (11:11 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 29 May 2025 10:37:42 +0000 (12:37 +0200)
commit54d34165b4f786d7fea8412a18fb4a54c1eab623
treee2e2ff58e807ab4024d70ccfc146414aa8405e04
parentba99c627aac85bc746fb4a6e2d79edb3ad100326
net/mlx4_en: Prevent potential integer overflow calculating Hz

The "freq" variable is in terms of MHz and "max_val_cycles" is in terms
of Hz.  The fact that "max_val_cycles" is a u64 suggests that support
for high frequency is intended but the "freq_khz * 1000" would overflow
the u32 type if we went above 4GHz.  Use unsigned long long type for the
mutliplication to prevent that.

Fixes: 31c128b66e5b ("net/mlx4_en: Choose time-stamping shift value according to HW frequency")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/aDbFHe19juIJKjsb@stanley.mountain
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/mellanox/mlx4/en_clock.c