]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: streamzap: prevent processing IR data on URB failure
authorMurad Masimov <m.masimov@mt-integration.ru>
Mon, 13 Jan 2025 10:51:31 +0000 (13:51 +0300)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 13 Feb 2025 11:12:30 +0000 (12:12 +0100)
commit549f6d348167fb2f7800ed7c8d4bce9630c74498
treed64743389d392fda638a1d072efac2b3830aedf1
parentf656cfbc7a293a039d6a0c7100e1c846845148c1
media: streamzap: prevent processing IR data on URB failure

If streamzap_callback() receives an urb with any non-critical error
status, i.e. any error code other than -ECONNRESET, -ENOENT or -ESHUTDOWN,
it will try to process IR data, ignoring a possible transfer failure.

Make streamzap_callback() process IR data only when urb->status is 0.
Move processing logic to a separate function to make code cleaner and
more similar to the URB completion handlers in other RC drivers.

Found by Linux Verification Center (linuxtesting.org) with Syzkaller.

Fixes: 19770693c354 ("V4L/DVB: staging/lirc: add lirc_streamzap driver")
Cc: stable@vger.kernel.org
Signed-off-by: Murad Masimov <m.masimov@mt-integration.ru>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/rc/streamzap.c