]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mailbox, remoteproc: omap2+: fix compile testing
authorArnd Bergmann <arnd@arndb.de>
Mon, 9 Sep 2024 20:38:09 +0000 (20:38 +0000)
committerJassi Brar <jassisinghbrar@gmail.com>
Fri, 27 Sep 2024 14:11:05 +0000 (09:11 -0500)
commit54595f2807d203770ee50486cb23dc5763916d72
tree56871ef0ad34b5733251b92ab6ebe5220c9ecfc2
parent5232544ea368b54b517dc504308c9e62bc6e87eb
mailbox, remoteproc: omap2+: fix compile testing

Selecting CONFIG_OMAP2PLUS_MBOX while compile testing
causes a build failure:

WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
  Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
  Selected by [m]:
  - TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])

Using 'select' to force-enable another subsystem is generally
a mistake and causes problems such as this one, so change the
three drivers that link against this driver to use 'depends on'
instead, and ensure the driver itself can be compile tested
regardless of the platform.

When compile-testing without CONFIG_TI_SCI_PROTOCOL=m, there
is a chance for a link failure, so add a careful dependency
on that.

arm-linux-gnueabi-ld: drivers/remoteproc/ti_k3_m4_remoteproc.o: in function `k3_m4_rproc_probe':
ti_k3_m4_remoteproc.c:(.text.k3_m4_rproc_probe+0x76): undefined reference to `devm_ti_sci_get_by_phandle'

Fixes: ebcf9008a895 ("remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Andrew Davis <afd@ti.com>
Reviewed-by: Martyn Welch <martyn.welch@collabora.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/Kconfig
drivers/mailbox/omap-mailbox.c
drivers/remoteproc/Kconfig