]> www.infradead.org Git - users/hch/block.git/commit
regmap: maple: work around gcc-14.1 false-positive warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 19 Jul 2024 10:40:24 +0000 (12:40 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jul 2024 12:04:04 +0000 (13:04 +0100)
commit542440fd7b30983cae23e32bd22f69a076ec7ef4
treeff7949711e335814366df1f5faaab3341c348820
parentc2bb8198fee88a428513f8d023c627ecd13aa694
regmap: maple: work around gcc-14.1 false-positive warning

With gcc-14.1, there is a false-postive -Wuninitialized warning in
regcache_maple_drop:

drivers/base/regmap/regcache-maple.c: In function 'regcache_maple_drop':
drivers/base/regmap/regcache-maple.c:113:23: error: 'lower_index' is used uninitialized [-Werror=uninitialized]
  113 |         unsigned long lower_index, lower_last;
      |                       ^~~~~~~~~~~
drivers/base/regmap/regcache-maple.c:113:36: error: 'lower_last' is used uninitialized [-Werror=uninitialized]
  113 |         unsigned long lower_index, lower_last;
      |                                    ^~~~~~~~~~

I've created a reduced test case to see if this needs to be reported
as a gcc, but it appears that the gcc-14.x branch already has a change
that turns this into a more sensible -Wmaybe-uninitialized warning, so
I ended up not reporting it so far.

The reduced test case also produces a warning for gcc-13 and gcc-12
but I don't see that with the version in the kernel.

Link: https://godbolt.org/z/oKbohKqd3
Link: https://lore.kernel.org/all/CAMuHMdWj=FLmkazPbYKPevDrcym2_HDb_U7Mb9YE9ovrP0jJfA@mail.gmail.com/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20240719104030.1382465-1-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regcache-maple.c