]> www.infradead.org Git - users/willy/xarray.git/commit
clk: ep93xx: Fix off by one in ep93xx_div_recalc_rate()
authorDan Carpenter <alexander.sverdlin@gmail.com>
Wed, 11 Sep 2024 07:39:15 +0000 (10:39 +0300)
committerArnd Bergmann <arnd@arndb.de>
Thu, 12 Sep 2024 14:33:12 +0000 (14:33 +0000)
commit53cf1dc480a5bdebad457cf6754ed3018b2533ba
treefd2afe7b625f216576eda3a7f7f8d61f3f726c47
parente2a79105903a9122c2717515454f9c05dd9081e4
clk: ep93xx: Fix off by one in ep93xx_div_recalc_rate()

The psc->div[] array has psc->num_div elements.  These values come from
when we call clk_hw_register_div().  It's adc_divisors and
ARRAY_SIZE(adc_divisors)) and so on.  So this condition needs to be >=
instead of > to prevent an out of bounds read.

Fixes: 9645ccc7bd7a ("ep93xx: clock: convert in-place to COMMON_CLK")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Reviewed-by: Nikita Shubin <nikita.shubin@maquefel.me>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Link: https://lore.kernel.org/r/1caf01ad4c0a8069535813c26c7f0b8ea011155e.camel@linaro.org
[arnd: the original patch was for arch/arm/mach-ep93xx/clock.c,
but the same bug ended up in arch/arm/mach-ep93xx/clock.c.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/clk/clk-ep93xx.c