]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: stmmac: Call xpcs_config_eee_mult_fact() only when xpcs is present
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Fri, 21 Mar 2025 10:35:01 +0000 (11:35 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 24 Mar 2025 20:26:02 +0000 (13:26 -0700)
commit53cd6820f5a05dd7f982f7da85af7d185b3e4992
tree7d636f62b0f15b4c0bfe27c505f70cd142d52d70
parentc61209eeb0b382f6a605160f06285fec7e3415e2
net: stmmac: Call xpcs_config_eee_mult_fact() only when xpcs is present

Some dwmac variants such as dwmac_socfpga don't use xpcs but lynx_pcs.

Don't call xpcs_config_eee_mult_fact() in this case, as this causes a
crash at init :

 Unable to handle kernel NULL pointer dereference at virtual address 00000039 when write

 [...]

 Call trace:
  xpcs_config_eee_mult_fact from stmmac_pcs_setup+0x40/0x10c
  stmmac_pcs_setup from stmmac_dvr_probe+0xc0c/0x1244
  stmmac_dvr_probe from socfpga_dwmac_probe+0x130/0x1bc
  socfpga_dwmac_probe from platform_probe+0x5c/0xb0

Fixes: 060fb27060e8 ("net: stmmac: call xpcs_config_eee_mult_fact()")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/20250321103502.1303539-1-maxime.chevallier@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c