]> www.infradead.org Git - users/jedix/linux-maple.git/commit
arm64: dts: rockchip: use cs-gpios for spi1 on ringneck
authorJakob Unterwurzacher <jakob.unterwurzacher@cherry.de>
Fri, 27 Jun 2025 13:17:12 +0000 (15:17 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Mon, 30 Jun 2025 09:07:55 +0000 (11:07 +0200)
commit53b6445ad08f07b6f4a84f1434f543196009ed89
treeffb9a0c5e2ed31ea02a0c034f8f946f03c8a20cf
parentc76bcc7d1f24e90a2d7b98d1e523d7524269fc56
arm64: dts: rockchip: use cs-gpios for spi1 on ringneck

Hardware CS has a very slow rise time of about 6us,
causing transmission errors when CS does not reach
high between transaction.

It looks like it's not driven actively when transitioning
from low to high but switched to input, so only the CPU
pull-up pulls it high, slowly. Transitions from high to low
are fast. On the oscilloscope, CS looks like an irregular sawtooth
pattern like this:
                         _____
              ^         /     |
      ^      /|        /      |
     /|     / |       /       |
    / |    /  |      /        |
___/  |___/   |_____/         |___

With cs-gpios we have a CS rise time of about 20ns, as it should be,
and CS looks rectangular.

This fixes the data errors when running a flashcp loop against a
m25p40 spi flash.

With the Rockchip 6.1 kernel we see the same slow rise time, but
for some reason CS is always high for long enough to reach a solid
high.

The RK3399 and RK3588 SoCs use the same SPI driver, so we also
checked our "Puma" (RK3399) and "Tiger" (RK3588) boards.
They do not have this problem. Hardware CS rise time is good.

Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
Cc: stable@vger.kernel.org
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@cherry.de>
Link: https://lore.kernel.org/r/20250627131715.1074308-1-jakob.unterwurzacher@cherry.de
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi