]> www.infradead.org Git - users/jedix/linux-maple.git/commit
powerpc64/ftrace: fix module loading without patchable function entries
authorAnthony Iliopoulos <ailiop@suse.com>
Tue, 4 Feb 2025 23:18:21 +0000 (00:18 +0100)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Tue, 15 Apr 2025 06:10:54 +0000 (11:40 +0530)
commit534f5a8ba27863141e29766467a3e1f61bcb47ac
treed85dfb4b2e99c02db816cfd7e057870981b24d77
parent9cf7e13fecbab0894f6986fc6986ab2eba8de52e
powerpc64/ftrace: fix module loading without patchable function entries

get_stubs_size assumes that there must always be at least one patchable
function entry, which is not always the case (modules that export data
but no code), otherwise it returns -ENOEXEC and thus the section header
sh_size is set to that value. During module_memory_alloc() the size is
passed to execmem_alloc() after being page-aligned and thus set to zero
which will cause it to fail the allocation (and thus module loading) as
__vmalloc_node_range() checks for zero-sized allocs and returns null:

[  115.466896] module_64: cast_common: doesn't contain __patchable_function_entries.
[  115.469189] ------------[ cut here ]------------
[  115.469496] WARNING: CPU: 0 PID: 274 at mm/vmalloc.c:3778 __vmalloc_node_range_noprof+0x8b4/0x8f0
...
[  115.478574] ---[ end trace 0000000000000000 ]---
[  115.479545] execmem: unable to allocate memory

Fix this by removing the check completely, since it is anyway not
helpful to propagate this as an error upwards.

Fixes: eec37961a56a ("powerpc64/ftrace: Move ftrace sequence out of line")
Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Acked-by: Naveen N Rao (AMD) <naveen@kernel.org>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250204231821.39140-1-ailiop@suse.com
arch/powerpc/kernel/module_64.c