]> www.infradead.org Git - users/willy/pagecache.git/commit
idpf: call set_real_num_queues in idpf_open
authorJoshua Hay <joshua.a.hay@intel.com>
Wed, 5 Feb 2025 02:08:11 +0000 (18:08 -0800)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 11 Feb 2025 17:13:11 +0000 (09:13 -0800)
commit52c11d31b5a1d1c747bb5f36cc4808e93e2348f4
tree0e7e051bdb7e6cc23e156cc2b7f0a8500bd49d94
parent2ff66c2f9ea4e9311e9a00004348b6c465bd5d3b
idpf: call set_real_num_queues in idpf_open

On initial driver load, alloc_etherdev_mqs is called with whatever max
queue values are provided by the control plane. However, if the driver
is loaded on a system where num_online_cpus() returns less than the max
queues, the netdev will think there are more queues than are actually
available. Only num_online_cpus() will be allocated, but
skb_get_queue_mapping(skb) could possibly return an index beyond the
range of allocated queues. Consequently, the packet is silently dropped
and it appears as if TX is broken.

Set the real number of queues during open so the netdev knows how many
queues will be allocated.

Fixes: 1c325aac10a8 ("idpf: configure resources for TX queues")
Signed-off-by: Joshua Hay <joshua.a.hay@intel.com>
Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
Tested-by: Samuel Salin <Samuel.salin@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/idpf/idpf_lib.c