]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: lenovo: select CONFIG_ACPI_PLATFORM_PROFILE
authorArnd Bergmann <arnd@arndb.de>
Wed, 22 Jan 2025 06:50:57 +0000 (07:50 +0100)
committerJiri Kosina <jkosina@suse.com>
Mon, 3 Feb 2025 09:54:27 +0000 (10:54 +0100)
commit52572cde8b4a44676557ccb67b035291833112c5
treef81cee6f9385e32b45dd4d3ad63ebdf97b8cda5c
parent7e0d1cff12b895f44f4ddc8cf50311bc1f775201
HID: lenovo: select CONFIG_ACPI_PLATFORM_PROFILE

A previous patch tried to fix this link failure:

x86_64-linux-ld: drivers/hid/hid-lenovo.o: in function `lenovo_raw_event':
hid-lenovo.c:(.text+0x22c): undefined reference to `platform_profile_cycle'

but got it wrong in three ways:

 - the link failure still exists with CONFIG_ACPI_PLATFORM_PROFILE=m
   when hid-lenovo is built-in

 - There is no way to manually enable CONFIG_ACPI_PLATFORM_PROFILE, as
   it is intended to be selected by its users.

Remove the broken #if check again and instead select the symbol like
the other users do. This requires adding a dependency on CONFIG_ACPI.

Fixes: 52e7d1f7c2fd ("HID: lenovo: Fix undefined platform_profile_cycle in ThinkPad X12 keyboard patch")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/Kconfig
drivers/hid/hid-lenovo.c