]> www.infradead.org Git - users/dwmw2/linux.git/commit
scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 23 May 2020 10:11:29 +0000 (13:11 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:48:57 +0000 (17:48 +0200)
commit510fe47005f3d13d910363cae086d5b71daf1ce2
tree3ecbaab311fb0f70ee03a2e0efb9980e5e833ea3
parente1377dc0715c4b2b03f8085927fda5db37c3b5b5
scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd()

[ Upstream commit 9d7464b18892332e35ff37f0b024429a1a9835e6 ]

The pr_debug() dereferences "cmd" after we already freed it by calling
tcmu_free_cmd(cmd).  The debug printk needs to be done earlier.

Link: https://lore.kernel.org/r/20200523101129.GB98132@mwanda
Fixes: 61fb24822166 ("scsi: target: tcmu: Userspace must not complete queued commands")
Reviewed-by: Mike Christie <mchristi@redhat.com>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/target/target_core_user.c