]> www.infradead.org Git - users/jedix/linux-maple.git/commit
arm64: probes: Fix simulate_ldr*_literal()
authorMark Rutland <mark.rutland@arm.com>
Tue, 8 Oct 2024 15:58:47 +0000 (16:58 +0100)
committerWill Deacon <will@kernel.org>
Wed, 9 Oct 2024 15:56:53 +0000 (16:56 +0100)
commit50f813e57601c22b6f26ced3193b9b94d70a2640
tree97381146eed47b62405cc182f23cae8d1609a643
parentacc450aa07099d071b18174c22a1119c57da8227
arm64: probes: Fix simulate_ldr*_literal()

The simulate_ldr_literal() code always loads a 64-bit quantity, and when
simulating a 32-bit load into a 'W' register, it discards the most
significant 32 bits. For big-endian kernels this means that the relevant
bits are discarded, and the value returned is the the subsequent 32 bits
in memory (i.e. the value at addr + 4).

Additionally, simulate_ldr_literal() and simulate_ldrsw_literal() use a
plain C load, which the compiler may tear or elide (e.g. if the target
is the zero register). Today this doesn't happen to matter, but it may
matter in future if trampoline code uses a LDR (literal) or LDRSW
(literal).

Update simulate_ldr_literal() and simulate_ldrsw_literal() to use an
appropriately-sized READ_ONCE() to perform the access, which avoids
these problems.

Fixes: 39a67d49ba35 ("arm64: kprobes instruction simulation support")
Cc: stable@vger.kernel.org
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20241008155851.801546-3-mark.rutland@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/probes/simulate-insn.c