]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/panthor: Let IRQ handlers clear the interrupts themselves
authorBoris Brezillon <boris.brezillon@collabora.com>
Fri, 4 Apr 2025 08:09:32 +0000 (10:09 +0200)
committerBoris Brezillon <boris.brezillon@collabora.com>
Thu, 10 Apr 2025 13:00:11 +0000 (15:00 +0200)
commit50b0639b575c0725a190926d17222193bdf027c9
treeec3283ec51c3180d16965e6d32806fddcb4e77df
parent8ba64cf2f358079d09faba7529aad2b0a46c7903
drm/panthor: Let IRQ handlers clear the interrupts themselves

MMU handler needs to be in control of the job interrupt clears because
clearing the interrupt also unblocks the writer/reader that triggered
the fault, and we don't want it to be unblocked until we've had a chance
to process the IRQ.

Since clearing the clearing is just one line, let's make it explicit
instead of doing it in the generic code path.

Note that this commit changes the existing behavior in that the MMU
COMPLETED irqs are no longer cleared, which is fine because they are
masked, so we're not risking an interrupt flood.

Changes in v3:
- Mention the fact we no longer clear MMU COMPLETED irqs
- Add Liviu's R-b

Changes in v2:
- Move the MMU_INT_CLEAR around

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/20250404080933.2912674-5-boris.brezillon@collabora.com
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
drivers/gpu/drm/panthor/panthor_device.h
drivers/gpu/drm/panthor/panthor_fw.c
drivers/gpu/drm/panthor/panthor_gpu.c
drivers/gpu/drm/panthor/panthor_mmu.c