]> www.infradead.org Git - users/dwmw2/linux.git/commit
Input: cap11xx - switch to using set_brightness_blocking()
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 5 Feb 2019 21:52:26 +0000 (13:52 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 19:09:44 +0000 (20:09 +0100)
commit4fe714b750cb8c8be5521548a208f623a7d2b51b
treecaf71cd210a4e5bc9fdb9ac4c903290527c1223b
parentf49f7007de5933e02228909a7ee95d71e5a44bc8
Input: cap11xx - switch to using set_brightness_blocking()

[ Upstream commit 628442880af8c201d307a45f3862a7a17df8a189 ]

Updating LED state requires access to regmap and therefore we may sleep,
so we could not do that directly form set_brightness() method.
Historically we used private work to adjust the brightness, but with the
introduction of set_brightness_blocking() we no longer need it.

As a bonus, not having our own work item means we do not have
use-after-free issue as we neglected to cancel outstanding work on
driver unbind.

Reported-by: Sven Van Asbroeck <thesven73@gmail.com>
Reviewed-by: Sven Van Asbroeck <TheSven73@googlemail.com>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/input/keyboard/cap11xx.c