]> www.infradead.org Git - users/dwmw2/linux.git/commit
mac80211: don't warn about CW params when not using them
authorBrian Norris <briannorris@chromium.org>
Thu, 18 Jul 2019 01:57:12 +0000 (18:57 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Aug 2019 08:13:51 +0000 (10:13 +0200)
commit4f4355e4cc3c73c7438ef1ad6f9a73aaa2a2bf92
treeb1a5673424ed2bca41a668c637e7672dedd325cd
parenta3e7eb590697f877fe740568b019938f6a12b10d
mac80211: don't warn about CW params when not using them

[ Upstream commit d2b3fe42bc629c2d4002f652b3abdfb2e72991c7 ]

ieee80211_set_wmm_default() normally sets up the initial CW min/max for
each queue, except that it skips doing this if the driver doesn't
support ->conf_tx. We still end up calling drv_conf_tx() in some cases
(e.g., ieee80211_reconfig()), which also still won't do anything
useful...except it complains here about the invalid CW parameters.

Let's just skip the WARN if we weren't going to do anything useful with
the parameters.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Link: https://lore.kernel.org/r/20190718015712.197499-1-briannorris@chromium.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/mac80211/driver-ops.c