]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf hist: Don't set hpp_fmt_value for members in --no-group
authorKan Liang <kan.liang@linux.intel.com>
Tue, 20 Aug 2024 18:32:02 +0000 (11:32 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 28 Aug 2024 21:07:20 +0000 (18:07 -0300)
commit4f3affe0abf5d5910dc469a1f63257629605d3c3
tree242588cff1cb39b1a9f8e8e9c83a7da8aa985867
parentf133c76409c81653cb580903da49aecefca67013
perf hist: Don't set hpp_fmt_value for members in --no-group

Perf crashes as below when applying --no-group

  # perf record -e "{cache-misses,branches"} -b sleep 1
  # perf report --stdio --no-group
  free(): invalid next size (fast)
  Aborted (core dumped)
  #

In the __hpp__fmt(), only 1 hpp_fmt_value is allocated for the current
event when --no-group is applied.

However, the current implementation tries to assign the hists from all
members to the hpp_fmt_value, which exceeds the allocated memory.

Fixes: 8f6071a3dce40e69 ("perf hist: Simplify __hpp_fmt() using hpp_fmt_data")
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240820183202.3174323-1-kan.liang@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/hist.c