]> www.infradead.org Git - users/dwmw2/linux.git/commit
taprio: Fix kernel panic in taprio_destroy
authorVladimir Oltean <olteanv@gmail.com>
Fri, 30 Aug 2019 01:07:21 +0000 (04:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 10 Sep 2019 09:35:08 +0000 (10:35 +0100)
commit4f15d0e51268376155951c11d58190e4026d062d
treecd01bc5c7dce886d2ce4d7b8d23b9be52de8016b
parent61f10b1bb84d7c21e64cf4d6ebf274a829fc850d
taprio: Fix kernel panic in taprio_destroy

taprio_init may fail earlier than this line:

list_add(&q->taprio_list, &taprio_list);

i.e. due to the net device not being multi queue.

Attempting to remove q from the global taprio_list when it is not part
of it will result in a kernel panic.

Fix it by matching list_add and list_del better to one another in the
order of operations. This way we can keep the deletion unconditional
and with lower complexity - O(1).

Cc: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
Fixes: 7b9eba7ba0c1 ("net/sched: taprio: fix picos_per_byte miscalculation")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sched/sch_taprio.c