]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iio: hid-sensor-prox: Split difference from multiple channels
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 16 Dec 2024 10:05:53 +0000 (10:05 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 3 Feb 2025 19:30:11 +0000 (19:30 +0000)
commit4eba4d92906c3814ca3ec65c16af27c46c12342e
treeb9af65aca7dcd14a08ac10e7162ed9ea7e653d06
parent5d702aa2a47bbab6231382f9ead5be40a287a53b
iio: hid-sensor-prox: Split difference from multiple channels

When the driver was originally created, it was decided that
sampling_frequency and hysteresis would be shared_per_type instead
of shared_by_all (even though it is internally shared by all). Eg:
in_proximity_raw
in_proximity_sampling_frequency

When we introduced support for more channels, we continued with
shared_by_type which. Eg:
in_proximity0_raw
in_proximity1_raw
in_proximity_sampling_frequency
in_attention_raw
in_attention_sampling_frequency

Ideally we should change to shared_by_all, but it is not an option,
because the current naming has been a stablished ABI by now. Luckily we
can use separate instead. That will be more consistent:
in_proximity0_raw
in_proximity0_sampling_frequency
in_proximity1_raw
in_proximity1_sampling_frequency
in_attention_raw
in_attention_sampling_frequency

Fixes: 596ef5cf654b ("iio: hid-sensor-prox: Add support for more channels")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Link: https://patch.msgid.link/20241216-fix-hid-sensor-v2-1-ff8c1959ec4a@chromium.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/hid-sensor-prox.c