]> www.infradead.org Git - users/jedix/linux-maple.git/commit
driver core: Fix size calculation of symlink name for devlink_(add|remove)_symlinks()
authorZijun Hu <quic_zijuhu@quicinc.com>
Fri, 12 Jul 2024 11:52:31 +0000 (19:52 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jul 2024 12:54:08 +0000 (14:54 +0200)
commit4ea5e9deda3f4cbd471d29e6e99106e51be19c86
tree90ed8bb0c09d9c90b8596c1de3e9827a6d2a3f5d
parent8400291e289ee6b2bf9779ff1c83a291501f017b
driver core: Fix size calculation of symlink name for devlink_(add|remove)_symlinks()

devlink_(add|remove)_symlinks() kzalloc() memory to save symlink name
for both supplier and consumer, but do not explicitly take into account
consumer's prefix "consumer:", so cause disadvantages listed below:
1) it seems wrong for the algorithm to calculate memory size
2) readers maybe need to count characters one by one of both prefix
   strings to confirm calculated memory size
3) it is relatively easy to introduce new bug if either prefix string
   is modified in future
solved by taking into account consumer's prefix as well.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20240712-devlink_fix-v3-1-fa1c5172ffc7@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c