]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bpf: Revert "bpf: remove unnecessary rcu_read_{lock,unlock}() in multi-uprobe attach...
authorDi Shen <di.shen@unisoc.com>
Tue, 20 May 2025 05:49:43 +0000 (13:49 +0800)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 22 May 2025 14:49:32 +0000 (07:49 -0700)
commit4e2e6841ff761cc15a54e8bebcf35d7325ec78a2
tree78095837215a39e22fa8d1ef43903393dc752437
parent25b6d5def6f8d3081f69c8b73cb934942c11e63a
bpf: Revert "bpf: remove unnecessary rcu_read_{lock,unlock}() in multi-uprobe attach logic"

This reverts commit 4a8f635a6054.

Althought get_pid_task() internally already calls rcu_read_lock() and
rcu_read_unlock(), the find_vpid() was not.

The documentation for find_vpid() clearly states:
"Must be called with the tasklist_lock or rcu_read_lock() held."

Add proper rcu_read_lock/unlock() to protect the find_vpid().

Fixes: 4a8f635a6054 ("bpf: remove unnecessary rcu_read_{lock,unlock}() in multi-uprobe attach logic")
Reported-by: Xuewen Yan <xuewen.yan@unisoc.com>
Signed-off-by: Di Shen <di.shen@unisoc.com>
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20250520054943.5002-1-xuewen.yan@unisoc.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/trace/bpf_trace.c