]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: phy: smsc: replace deprecated strncpy with ethtool_sprintf
authorJustin Stitt <justinstitt@google.com>
Thu, 12 Oct 2023 22:27:52 +0000 (22:27 +0000)
committerJakub Kicinski <kuba@kernel.org>
Mon, 16 Oct 2023 23:15:00 +0000 (16:15 -0700)
commit4ddc1f1f7339e0a03bbf235a6670d497bbb22fb3
tree5754d533d99b5f7b88b6bdcc7e891f23160b8bdc
parenteb7fa2eb9689b050b84333d62bbf79f803bbf1ef
net: phy: smsc: replace deprecated strncpy with ethtool_sprintf

strncpy() is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.

ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy in favor of this dedicated helper function.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20231012-strncpy-drivers-net-phy-smsc-c-v1-1-00528f7524b3@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/smsc.c