]> www.infradead.org Git - users/jedix/linux-maple.git/commit
tg3: Fix advertisement handling
authorJoe Jin <joe.jin@oracle.com>
Wed, 16 May 2012 03:19:28 +0000 (11:19 +0800)
committerJoe Jin <joe.jin@oracle.com>
Wed, 16 May 2012 03:19:28 +0000 (11:19 +0800)
commit4dd85ea06a09b4a34b7fa10c6294be1ccb1a995e
treeadca247e77ffdf8b5708b8da55a10ce59839b48d
parent3ef06ff35858e9178f3d7cbfd76ec22e4c33e54a
tg3: Fix advertisement handling

Commit 28011cf19b (net: Add ethtool to mii advertisment conversion
helpers) added a helper function ethtool_adv_to_mii_100bt() and
tg3_copper_is_advertising_all(), tg3_phy_autoneg_cfg() were
modified to use this.
Before that commit, ethtool to mii advertisement conversion was
done wrt speed, but now pause operation is also taken account.
So, in tg3_copper_is_advertising_all(), below condition becomes
true and this makes link up fails.

if ((adv_reg & ADVERTISE_ALL) != all_mask)
return 0;

To fix this add ADVERTISE_ALL bit and operation to cap speed,
and change default advertisement not including ADVERTISED_Pause.

(backported from commit 202ff1c26c768efeead20b388556eda265dc8352)
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
drivers/net/tg3.c