]> www.infradead.org Git - users/dwmw2/linux.git/commit
usb: dwc3: trace: add missing break statement to make compiler happy
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 3 Dec 2018 09:28:47 +0000 (11:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Feb 2019 19:02:15 +0000 (20:02 +0100)
commit4dc2acb15d52af484ee1155aee9ae53474827647
treebae7517e14538092d256b072f4d5fccb0c8c1f06
parent16946d7f820b06e5e18e39b2a85cb99c363c2f0c
usb: dwc3: trace: add missing break statement to make compiler happy

[ Upstream commit 54d48183d21e03f780053d7129312049cb5dd591 ]

The missed break statement in the outer switch makes the code fall through
always and thus always same value will be printed.

Besides that, compiler warns about missed fall through marker:

drivers/usb/dwc3/./trace.h: In function ‘trace_raw_output_dwc3_log_trb’:
drivers/usb/dwc3/./trace.h:246:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    switch (pcm) {
    ^~~~~~

Add the missing break statement to work correctly without compilation
warnings.

Fixes: fa8d965d736b ("usb: dwc3: trace: pretty print high-bandwidth transfers too")
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/dwc3/trace.h