]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: libfcoe: Replace all non-returning strlcpy() with strscpy()
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 30 May 2023 15:58:18 +0000 (15:58 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 31 May 2023 22:00:06 +0000 (18:00 -0400)
commit4dae0262fb990873adad012dc8338f99cbca8574
tree040c234d2d97dc71a005fe8d118c28a7589ed27e
parent73be26b12dfd209e136da01dd7eefc85adc4df8d
scsi: libfcoe: Replace all non-returning strlcpy() with strscpy()

strlcpy() reads the entire source buffer first.  This read may exceed the
destination size limit.  This is both inefficient and can lead to linear
read overflows if a source string is not NUL-terminated [1].  In an effort
to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Link: https://lore.kernel.org/r/20230530155818.368562-1-azeemshaikh38@gmail.com
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/fcoe/fcoe_transport.c