]> www.infradead.org Git - users/dwmw2/linux.git/commit
ethtool: Fix context creation with no parameters
authorGal Pressman <gal@nvidia.com>
Wed, 7 Aug 2024 17:33:52 +0000 (20:33 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 Aug 2024 15:57:55 +0000 (08:57 -0700)
commit4d7c3c1aba3ca12fad2e90163b8d5153363f93e5
treeb7892da35f3ada3f47db90526e87d4340812c538
parentb54de55990b0467538c6bb33523b28816384958a
ethtool: Fix context creation with no parameters

The 'at least one change' requirement is not applicable for context
creation, skip the check in such case.
This allows a command such as 'ethtool -X eth0 context new' to work.

The command works by mistake when using older versions of userspace
ethtool due to an incompatibility issue where rxfh.input_xfrm is passed
as zero (unset) instead of RXH_XFRM_NO_CHANGE as done with recent
userspace. This patch does not try to solve the incompatibility issue.

Link: https://lore.kernel.org/netdev/05ae8316-d3aa-4356-98c6-55ed4253c8a7@nvidia.com/
Fixes: 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS spreading of filter matches")
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: Jianbo Liu <jianbol@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://patch.msgid.link/20240807173352.3501746-1-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/ioctl.c